-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing in ReadableSpan #3528
Conversation
There's a lot more of this work that needs to be done across all of the repo(s). Is there any appetite for this from the maintainer team? |
Also I'd skip this from the changelog if possible since it's (mostly) an internal refactor |
Only the |
+1 to that, I'd love to have typing working on the SDK. This is tracked in #1608 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit on the PR title, seems like we're simplifying some things as well not just updating the type annotations
@srikanthccv this is ready for review |
Thanks folks! |
Description
This fixes some incorrect typing in ReadableSpan, including assumptions about the type of
attributes
which causes a bug when they're not aBoundedAttributes
instance.How Has This Been Tested?
This is a refactor so I'm relying on the existing tests
Does This PR Require a Contrib Repo Change?
Checklist: