Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Exporter string representation for target_info labels #3659

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

kornerc
Copy link
Contributor

@kornerc kornerc commented Jan 31, 2024

Description

Fixes #3676

Labels of the target_info metric must be exported in a string representation.

Furthermore the test_target_info_enabled_by_default contained some dead code due to a wrong list slicing.
python_list[:0] returns always an empty list.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran the unit tests.

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

test_target_info_enabled_by_default contained some dead code due to a wrong list slicling
@kornerc kornerc marked this pull request as ready for review January 31, 2024 18:45
@kornerc kornerc requested a review from a team January 31, 2024 18:45
@kornerc kornerc changed the title Prometheus Exporter fix test_target_info_enabled_by_default Prometheus Exporter find string representation for target_info key-value pairs Feb 6, 2024
@kornerc kornerc changed the title Prometheus Exporter find string representation for target_info key-value pairs Prometheus Exporter string representation for target_info labels Feb 6, 2024
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ocelotl ocelotl merged commit 39f0f82 into open-telemetry:main Feb 9, 2024
270 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus exporter target_info key-value pairs must be string
3 participants