Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix benchmark reporting #3773

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Mar 12, 2024

Description

The benchmark ci workflow is currently failling because tox output is not found by the benchmarking action.
Use the same tests output path to have the reporting tool find it.
If this does not run on PR I have no way to test this.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • CI run?

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team March 12, 2024 17:10
Use the same tests output path to have the reporting tool find it.
@xrmx xrmx force-pushed the fixup-benchmark-results-workflow branch from b6dbb3e to b4cfee6 Compare March 13, 2024 10:14
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 14, 2024
@ocelotl ocelotl merged commit 88eda0a into open-telemetry:main Mar 14, 2024
233 of 234 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants