Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proto version to v1.2.0 #3844

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Update proto version to v1.2.0 #3844

merged 5 commits into from
Apr 10, 2024

Conversation

srikanthccv
Copy link
Member

Description

This change bumps the proto version to latest release v1.2.0

@srikanthccv srikanthccv requested a review from a team April 9, 2024 14:52
aabmass
aabmass approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but is there an issue tracking this? Any breaking changes?

opentelemetry-proto/README.rst Show resolved Hide resolved
aabmass
aabmass requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until we confirm the breaking change status.

@srikanthccv
Copy link
Member Author

There have been a few additions since 0.20.0 (release candidate for 1.0.0) but no breaking changes.

aabmass
aabmass approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG thanks! Can you add a changelog entry?

@aabmass aabmass added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Apr 10, 2024
@lzchen lzchen merged commit 1164ab6 into open-telemetry:main Apr 10, 2024
233 checks passed
@srikanthccv srikanthccv deleted the update-proto branch April 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen left review comments

@aabmass aabmass aabmass approved these changes

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srikanthccv @xrmx @aabmass @lzchen