build(scripts-tracecontext-integration-test.sh): fixed issue #4105 #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emetry#4105: updated TRACECONTEXT_GIT_TAG to latest
emdneto
reviewed
Aug 7, 2024
| @@ -1639,3 +1639,5 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ([#3778](https://github.com/open-telemetry/opentelemetry-python/pull/3778)) | |||
| - Fix license field in pyproject.toml files | |||
| ([#3803](https://github.com/open-telemetry/opentelemetry-python/pull/3803)) | |||
| - bump trace-context to e99a85d12df8c25c51ec1d5d234f20e918265b75 | |||
| ([#4109](https://github.com/open-telemetry/opentelemetry-python/pull/4109)) | |||
There was a problem hiding this comment.
You should move this to the "# Unreleased" section at the beginning of the CHANGELOG.md file
emdneto
reviewed
Aug 7, 2024
| # hard-coding the git tag to ensure stable builds. | ||
| TRACECONTEXT_GIT_TAG="98f210efd89c63593dce90e2bae0a1bdcb986f51" | ||
| TRACECONTEXT_GIT_TAG="e99a85d12df8c25c51ec1d5d234f20e918265b75" |
There was a problem hiding this comment.
I think won't be so to easy to point to the lastest :) There's a failing test test_tracestate_duplicated_keys.
The test_tracestate_duplicated_keys was broken, it demanded to drop
the whole tracestate when a duplicate key was found. This does not match
what the specification mandates in that situation. Instead,
implementations MAY remove the duplicates from tracestate or even leave
them in as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated TRACECONTEXT_GIT_TAG to latest
Description
Fixes #4105
updated TRACECONTEXT_GIT_TAG version for avoid warnings in test time
Type of change
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: