Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: test Event name precedence in attributes #4142

Merged
merged 1 commit into from
Aug 22, 2024
Merged

events: test Event name precedence in attributes #4142

merged 1 commit into from
Aug 22, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Aug 22, 2024

Description

Add a test for the newly added Events API for the behaviour of giving precedence to the Event instance name over an event.name entry in attributes.

Refs #4054

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py310-test-opentelemetry-api

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team August 22, 2024 06:32
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 22, 2024
@xrmx xrmx force-pushed the test-event-attributes-name-precedence branch from d294c9a to c50958a Compare August 22, 2024 08:15
@lzchen lzchen merged commit fe67d45 into open-telemetry:main Aug 22, 2024
376 checks passed
hyoinandout pushed a commit to hyoinandout/opentelemetry-python that referenced this pull request Aug 29, 2024
@xrmx @hyoinandout
events: test Event name precedence in attributes (open-telemetry#4142)
373976a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@emdneto emdneto emdneto approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrmx @emdneto @lzchen