opentelemetry-api: allow importlib-metadata up to 8.4.0 #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
changed the title
xrmx
approved these changes
Aug 22, 2024
I think this kind of update deserves a CHANGELOG.md entry, but we didn't do that in the previous PRs. So we can start with this one |
emdneto
approved these changes
Aug 22, 2024
lzchen
approved these changes
Aug 22, 2024
tammy-baylis-swi
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
I think this minor version bump should be fine, since mentioned briefly at the sig meeting.
The change will not fix this one open issue: #3234 (comment)
But the change won't undo previous bumps or conditions for Python version. Here are some past PRs for this dep:
- https://github.com/open-telemetry/opentelemetry-python/pull/3217/files
- https://github.com/open-telemetry/opentelemetry-python/pull/3334/files
- https://github.com/open-telemetry/opentelemetry-python/pull/3403/files
- https://github.com/open-telemetry/opentelemetry-python/pull/3406/files
- https://github.com/open-telemetry/opentelemetry-python/pull/3576/files
- https://github.com/open-telemetry/opentelemetry-python/pull/3835/files
- https://github.com/open-telemetry/opentelemetry-python/pull/3994/files
- https://github.com/open-telemetry/opentelemetry-python/pull/4007/files
- https://github.com/open-telemetry/opentelemetry-python/pull/4089/files
|
@tammy-baylis-swi Forgot about that issue, thanks for mentioning it. We should probably try to stop using it on recent Python versions and / or update the comment to mention 3.10 and not 3.12 😅 |
hyoinandout
pushed a commit
to hyoinandout/opentelemetry-python
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on this PR.
Adjust cap on importlib-metadata
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: