-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused assertEqualSpanInstrumentationInfo #4310
Remove unused assertEqualSpanInstrumentationInfo #4310
Conversation
I am not sure if our stability guarantees extend to testing utils so I am fine with removing it outright. I am also not against adding a warning about the removal and remove it in a subsequent release. Feel free to bring it up in the SIG so we can get a concensus. |
There were warnings at runtime already when using it because the helper was accessing a deprecated property so it shouldn't come as a surpise 😅 |
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Description
It doesn't look like this repo uses assertEqualSpanInstrumentationInfo (grep).
All contrib repo uses were removed in open-telemetry/opentelemetry-python-contrib#3037.
This will break testing for any users that do
from opentelemetry.test.test_base import TestBase
and use assertEqualSpanInstrumentationInfo. However, there should have been warnings logged that lookup of instrumentation info has been deprecatedsince version 1.11.1
via calls to that helper instead of assertEqualSpanInstrumentationScope (see contrib issue OP)Alternatively: We could add a
logger
to test_base or useprint
/sys.stdout
to show a warning that assertEqualSpanInstrumentationInfo will be removed in a future release. Is that the approach we prefer?Fixes #4301
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Run all unit tests.
Does This PR Require a Contrib Repo Change?
Checklist: