Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: pustil -> psutil #4311

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Fix typo: pustil -> psutil #4311

merged 6 commits into from
Nov 26, 2024

Conversation

stevapple
Copy link
Contributor

Description

Fixes a typo in opentelemetry.sdk.resources which makes user detection not functioning.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@stevapple stevapple requested a review from a team as a code owner November 23, 2024 17:31
Copy link

linux-foundation-easycla bot commented Nov 23, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@xrmx
Copy link
Contributor

xrmx commented Nov 25, 2024

@stevapple please add a changelog entry

@xrmx
Copy link
Contributor

xrmx commented Nov 26, 2024

Updated changelog and added psutil to test requirements so that we test the code

@xrmx xrmx enabled auto-merge (squash) November 26, 2024 08:42
@xrmx xrmx merged commit 1ee2774 into open-telemetry:main Nov 26, 2024
353 checks passed
@stevapple stevapple deleted the patch-2 branch December 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants