Improvements for requests integration #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestBase class wraps a tracer provider that is configured with a memory span exporter. This class inherits from unitest.TestCase, hence other test classes can inherit from it to get access to the underlying memory span exporter and tracer provider.
This mock propagator could be use for testing propagation in different packages. It was implemented in the opentracing-shim and this commit moves it to a generic place.
disable_session() can be used to disable the instrumentation on a single requests' session object.
This commit refactor the tests: - Use the TestBase class, removing all the mocking around - Add new tests
codeboten
reviewed
Apr 14, 2020
codeboten
reviewed
Apr 14, 2020
| @@ -129,3 +127,10 @@ def disable(): | |||
| if getattr(Session.request, "opentelemetry_ext_requests_applied", False): | |||
There was a problem hiding this comment.
should disable_session be used here as well?
There was a problem hiding this comment.
Those are slightly different, this one modifies Session.request, i.e, the method in the whole class, while disable_session only modifies the request method on that object.
codeboten
approved these changes
Apr 14, 2020
toumorokoshi
approved these changes
Apr 14, 2020
| ) | ||
|
|
||
|
|
||
| class TestBase(unittest.TestCase): |
| span_list = self.memory_exporter.get_finished_spans() | ||
| self.assertEqual(len(span_list), 1) | ||
|
|
||
| def test_suppress_instrumentation(self): |
There was a problem hiding this comment.
unrelated to this PR, but you reminded me that we should handle instrumentation suppression on a different layer: #581. Then we can remove this test.
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* chore: add missing default plugins * chore: update plugin list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started porting the Datadog version of this integration (open-telemetry/opentelemetry-python-contrib#23) to get familiar with the process, while doing so I realized some of the things we are missing in the current integration. The goal of this PR is to improve the current implementation / tests, in a following PR the instrumentor logic will be added.
unittest.mockto SDK & in-memory exporter #303)Fixes #479
This will conflict with #559, I can update it when that's merged.