Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proto files #728

Merged
merged 9 commits into from
Jun 9, 2020
Merged

Add proto files #728

merged 9 commits into from
Jun 9, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented May 24, 2020 •
edited
Loading

Fixes #785

@codeboten codeboten changed the title Issue 669 OTLP Trace exporter Jun 4, 2020
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 6, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@ocelotl ocelotl force-pushed the issue_669 branch 3 times, most recently from 09cad43 to 6a170f9 Compare June 7, 2020 00:12
@ocelotl ocelotl changed the title OTLP Trace exporter Add proto files Jun 7, 2020
@ocelotl ocelotl self-assigned this Jun 7, 2020
@ocelotl ocelotl marked this pull request as ready for review June 7, 2020 00:16
@ocelotl ocelotl requested a review from a team June 7, 2020 00:16
codeboten
codeboten suggested changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions, would be great to get this in quickly.

opentelemetry-proto/CHANGELOG.md Show resolved Hide resolved
opentelemetry-proto/README.rst Show resolved Hide resolved
opentelemetry-proto/setup.cfg Outdated Show resolved Hide resolved
opentelemetry-proto/src/opentelemetry/proto/version.py Outdated Show resolved Hide resolved
opentelemetry-proto/README.rst Show resolved Hide resolved
@codeboten codeboten added this to the Beta v0.9 milestone Jun 8, 2020
@ocelotl ocelotl force-pushed the issue_669 branch 2 times, most recently from 9a7d7fa to ec86070 Compare June 8, 2020 20:13
codeboten
codeboten approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

toumorokoshi
toumorokoshi approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@toumorokoshi toumorokoshi merged commit 7acb565 into open-telemetry:master Jun 9, 2020
@toumorokoshi toumorokoshi mentioned this pull request Jun 9, 2020
Closed
codeboten added a commit to codeboten/opentelemetry-python that referenced this pull request Jun 11, 2020
@ocelotl @codeboten @toumorokoshi
proto: Add proto files (open-telemetry#728)
5a29964 
Initial addition of opentelemetry-proto based protobufs.

Co-authored-by: alrex <alrex.boten@gmail.com>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
@aabmass aabmass mentioned this pull request Jun 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
Beta v0.9
Development

Successfully merging this pull request may close these issues.

Add opentelemetry proto files
3 participants
@ocelotl @codeboten @toumorokoshi