Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datadog): set sampling rate #740

Merged

Conversation

majorgreys
Copy link
Contributor

Set the sampling rate in the Datadog exported span if span was sampled with the ProbabilitySampler.

@majorgreys majorgreys requested a review from a team May 27, 2020 18:01
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. thanks!

@toumorokoshi
Copy link
Member

@majorgreys can you look at @ocelotl's nitpick and update your branch? can merge when you confirm receipt, even if you don't apply the change.

majorgreys and others added 2 commits May 28, 2020 13:22
@majorgreys
Copy link
Contributor Author

@toumorokoshi good to go!

@toumorokoshi toumorokoshi merged commit 30c953d into open-telemetry:master May 28, 2020
@majorgreys majorgreys deleted the majorgreys/datadog-sampling-rate branch May 28, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants