Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Observer to ValueObserver #764

Merged
merged 16 commits into from
Jun 8, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jun 2, 2020

Part of [#753].

Name change.

ValueObservers are an API element, so default implementations were made for them in the API.

@lzchen lzchen requested a review from a team June 2, 2020 02:34
@c24t
Copy link
Member

c24t commented Jun 2, 2020

See also #761.

@codeboten codeboten added this to the Beta v0.9 milestone Jun 4, 2020
@lzchen lzchen added metrics api Affects the API package. needs reviewers PRs with this label are ready for review and needs people to review to move forward. labels Jun 4, 2020
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested in the changelog, otherwise this looks good!

opentelemetry-sdk/CHANGELOG.md Outdated Show resolved Hide resolved
@codeboten codeboten merged commit d755375 into open-telemetry:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the API package. metrics needs reviewers PRs with this label are ready for review and needs people to review to move forward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants