Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gco agent span label #833

Merged
merged 19 commits into from
Jun 22, 2020
Merged

Conversation

AndrewAXue
Copy link
Contributor

No description provided.

@AndrewAXue AndrewAXue requested a review from a team June 16, 2020 21:50
Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and questions, LGTM otherwise.

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lzchen lzchen merged commit b2c0d53 into open-telemetry:master Jun 22, 2020
@AndrewAXue AndrewAXue deleted the cloud_trace_gco branch June 22, 2020 19:49
AndrewAXue pushed a commit to AndrewAXue/opentelemetry-python that referenced this pull request Jun 22, 2020
add uuid label to metricdescriptor
AndrewAXue pushed a commit to AndrewAXue/opentelemetry-python that referenced this pull request Jun 22, 2020
add uuid label to metricdescriptor
cnnradams pushed a commit to cnnradams/opentelemetry-python that referenced this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants