Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment variable names #904

Merged
merged 7 commits into from
Jul 30, 2020
Merged

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jul 13, 2020

Fixes #903

@ocelotl ocelotl requested a review from a team July 13, 2020 15:46
@ocelotl ocelotl self-assigned this Jul 13, 2020
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this doesn't conform to the spec referenced, primarily the prefix should be OTEL_PYTHON_*

docs/examples/django/README.rst Outdated Show resolved Hide resolved
@lzchen
Copy link
Contributor

lzchen commented Jul 17, 2020

I think we're missing a OPENTELEMETRY_CONTEXT in the api package.

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 18, 2020

I think we're missing a OPENTELEMETRY_CONTEXT in the api package.

do you mean an OTEL_CONTEXT environment variable? The Configuration object will automatically read it if present.

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 18, 2020

I believe this doesn't conform to the spec referenced, primarily the prefix should be OTEL_PYTHON_*

Fixed

@ocelotl ocelotl requested a review from codeboten July 18, 2020 02:59
@lzchen
Copy link
Contributor

lzchen commented Jul 20, 2020

I think we're missing a OPENTELEMETRY_CONTEXT in the api package.

do you mean an OTEL_CONTEXT environment variable? The Configuration object will automatically read it if present.

https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-api/src/opentelemetry/context/__init__.py#L58

Should probably be renamed to OTEL_CONTEXT right?

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 20, 2020

I think we're missing a OPENTELEMETRY_CONTEXT in the api package.

do you mean an OTEL_CONTEXT environment variable? The Configuration object will automatically read it if present.

https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-api/src/opentelemetry/context/__init__.py#L58

Should probably be renamed to OTEL_CONTEXT right?

Right, fixed.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelogs as this impacts users.

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 22, 2020

Please update the changelogs as this impacts users.

Fixed

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see an entry in the change logs for all the packages affected by this change

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 25, 2020

I'd like to see an entry in the change logs for all the packages affected by this change

Fixed

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Moved to approve, will merge once the conflicts have been resolved @ocelotl

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 29, 2020

Thanks for the updates. Moved to approve, will merge once the conflicts have been resolved @ocelotl

Fixed

@codeboten
Copy link
Contributor

Looks like there's still a request for change pending on @toumorokoshi

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@lzchen lzchen merged commit 8c4fca5 into open-telemetry:master Jul 30, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update environment variable names
4 participants