Rename remaining framework packages from "ext" to "instrumentation" #969
Conversation
lzchen
changed the title
lzchen
changed the title
docs/getting-started.rst
Outdated
| Install the OpenTelemetry Collector exporter: | ||
|
|
||
| .. code-block:: sh | ||
|
|
||
| pip install opentelemetry-ext-otcollector | ||
|
|
||
| And execute the following script: | ||
|
|
||
| .. literalinclude:: getting_started/otcollector_example.py | ||
| :language: python | ||
| :lines: 15- |
There was a problem hiding this comment.
Yeah otcollector is now opencensus exporter or opentelemetry exporter, i think we need new getting started for either one of those (probably OT). Probably will be good once the metrics exporter is done for otlp.
There was a problem hiding this comment.
Oh looks like @ocelotl has already fixed this in his other PR. I'll add this back.
| @@ -422,7 +422,7 @@ def test_log_kv(self): | |||
| ) | |||
| self.assertEqual(span.unwrap().events[1].attributes["foo"], "bar") | |||
| # Tolerate inaccuracies of less than a microsecond. See Note: | |||
| # https://open-telemetry.github.io/opentelemetry-python/opentelemetry.ext.opentracing_shim.html | |||
| # https://open-telemetry.github.io/opentelemetry-python/opentelemetry.instrumentation.opentracing_shim.html | |||
There was a problem hiding this comment.
As a sanity check, I tried both of these URLs, and they both 404 😅
- https://open-telemetry.github.io/opentelemetry-python/opentelemetry.ext.opentracing_shim.html
- https://open-telemetry.github.io/opentelemetry-python/opentelemetry.instrumentation.opentracing_shim.html
I think it should be https://open-telemetry.github.io/opentelemetry-python/instrumentation/opentracing_shim/opentracing_shim.html
There was a problem hiding this comment.
Oh good catch. I'm assuming it uses the structure of the docs folder to find the page? I'm not too familiar with what https://open-telemetry.github.io is. Is this still read-the-docs?
* chore: move plugins to contrib
Description
Part of [#760]. Renaming remaining packages.
Checklist:
changelogs
folder name ext -> subfolder ext
setup.cfg/setup.py
tox
README
Moved docker-tests under /tests folder.