-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add some clarity to ottrace docs #522
docs: Add some clarity to ottrace docs #522
Conversation
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
@mwear hold on... I committed your changes a little too soon
8 bytes (64 bit) or 16 bytes (128 bit) |
☝️ is correct. I'm not sure if we should clarify the inject vs extract case, if you just want to go with what we originally had (before my suggestion). |
propagator/ottrace/README.md
Outdated
|
||
In order to do that Lightstep released a version of the OTTrace propagators in OpenTracing SDKs that left padded 8 byte headers to 16 bytes using an additional 8 bytes of 0s. | ||
|
||
The reality of the world is not every application upgraded to support 16 byte array propagation format, but this propagator must still convert legacy 8 byte trace ids to match the W3C Trace Context Trace ID 16 byte array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reality of the world is not every application upgraded to support 16 byte array propagation format, but this propagator must still convert legacy 8 byte trace ids to match the W3C Trace Context Trace ID 16 byte array. | |
The reality of the world is not every application upgraded to support 16 byte array propagation format, but this propagator must still convert legacy 64 but trace ids to match the W3C Trace Context Trace ID 16 byte array. |
Co-authored-by: Ariel Valentin <arielvalentin@users.noreply.github.com>
Co-authored-by: Ariel Valentin <arielvalentin@users.noreply.github.com>
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
Fixes #521