Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing binary format #208

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Removing binary format #208

merged 1 commit into from
Mar 18, 2020

Conversation

minond
Copy link
Contributor

@minond minond commented Mar 16, 2020

Resolves #194

@minond
Copy link
Contributor Author

minond commented Mar 16, 2020

I signed the CLA before creating this PR, so I'm not sure why that step is failing. I'm double checking I did everything right.

@mwear
Copy link
Member

mwear commented Mar 17, 2020

👋 welcome @minond! If you're still having issues with signing the CLA, you can take a look at the FAQ here: https://identity.linuxfoundation.org/projects/cncf.

@minond
Copy link
Contributor Author

minond commented Mar 18, 2020

I signed it

@minond minond force-pushed the removing-binary-format branch from cd5eb73 to f0ccebd Compare March 18, 2020 01:10
@minond minond force-pushed the removing-binary-format branch from f0ccebd to 1c6f298 Compare March 18, 2020 01:13
@minond
Copy link
Contributor Author

minond commented Mar 18, 2020

cough cough ok... I guess the third time's the charm. @mwear, this is ready for review when you are.

mwear
mwear approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minond!

@mwear mwear merged commit 731aa1e into open-telemetry:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@fbogsany fbogsany fbogsany approved these changes

@bai bai Awaiting requested review from bai

@dazuma dazuma Awaiting requested review from dazuma

@elskwid elskwid Awaiting requested review from elskwid

@luvtechno luvtechno Awaiting requested review from luvtechno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove binary format
3 participants
@minond @mwear @fbogsany