Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add CodeQL Actions Beta #929

Closed
wants to merge 2 commits into from
Closed

chore: Add CodeQL Actions Beta #929

wants to merge 2 commits into from

Conversation

arielvalentin
Copy link
Contributor

@arielvalentin arielvalentin commented Aug 24, 2021

Fixes #767

The CodeQL Analysis Code scanning alerts will appear configured once it is merged into the upstream repository from the fork.

@arielvalentin arielvalentin self-assigned this Aug 24, 2021
@ahayworth
Copy link
Contributor

This looks nice! Is it supposed to show up here?
Screen Shot 2021-08-24 at 8 34 20 AM

(I'm assuming that either means there were no problems found - yay - or that there's feature flag to be toggled for this repo or something?)

@arielvalentin
Copy link
Contributor Author

I am not sure yet. Im waiting on confirmation from the CodeQL team that I configured this properly and the feature was enabled in the repo.

@fbogsany
Copy link
Contributor

I think we should just assume it means our code is perfect 😉

@arielvalentin arielvalentin marked this pull request as ready for review August 24, 2021 19:31
Copy link
Contributor

@ahayworth ahayworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arielvalentin arielvalentin marked this pull request as draft August 24, 2021 19:41
@arielvalentin
Copy link
Contributor Author

Hmm something is not quite right. The CodeQL action workflow file did not update nor did it update the action to make it possible to trigger manually. I am going to reopen close and reopen this PR to see if the action workflow changes as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need for a Viable Security Scanning Tool
3 participants