Use 4318 as the default OLTP exporter port #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcharna
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
mwear and
robertlaurin
as code owners
|
|
arielvalentin
approved these changes
Aug 24, 2021
fbogsany
requested changes
Aug 25, 2021
There was a problem hiding this comment.
Blocking this for now. The port change in the spec was reverted in open-telemetry/opentelemetry-specification#1847 until a prototype PR in the collector determines whether it is in fact possible for gRPC and HTTP to share a port. We can merge or close this once that’s resolved one way or another.
|
open-telemetry/opentelemetry-specification#1970 it has been changed to 4318 |
fbogsany
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collector has changed to use port 4318 by default in open-telemetry/opentelemetry-collector#3743.