Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes #1711

Merged
merged 1 commit into from
May 6, 2024
Merged

Minor changes #1711

merged 1 commit into from
May 6, 2024

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented May 6, 2024

Changes

@cijothomas
Copy link
Member

Docs CI check is broken in main branch. @utpilla Would you be able to help fix that?

@lalitb
Copy link
Member

lalitb commented May 6, 2024

Docs CI check is broken in main branch

I think this is the bug in the nightly - rust-lang/rust#124735.
The PR is merged - , so hopefully next nightly should be through.

I don't know whether we should continue using nightly for docs, or just use the stable?

@cijothomas
Copy link
Member

Docs CI check is broken in main branch

I think this is the bug in the nightly - rust-lang/rust#124735. The PR is merged - , so hopefully next nightly should be through.

I don't know whether we should continue using nightly for docs, or just use the stable?

I think stable is fine for the docs. The CI for test is doing both stable and beta.

@lalitb
Copy link
Member

lalitb commented May 6, 2024

@hdost @TommyCpp Just in case you have any suggestion on switching to stable/beta for docs? I do see few other rust repos (tracing, reqwest, hyper to name few) also testing on nightly, so not sure of the right approach.

@cijothomas
Copy link
Member

image

Merging, bypassing the branch protection. This is allowed and not required to be part of audit trail : https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#collaborators-and-teams

other than temporarily disabling "Do not allow bypassing the above settings", see branch protection rules below

@cijothomas cijothomas merged commit 6c9385c into open-telemetry:main May 6, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants