-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cardinality limits for metrics streams #1889
Conversation
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1889 +/- ##
=======================================
- Coverage 74.6% 74.6% -0.1%
=======================================
Files 122 122
Lines 19952 19955 +3
=======================================
Hits 14902 14902
- Misses 5050 5053 +3 ☔ View full report in Codecov by Sentry. |
4ff39f6
to
7c6ab69
Compare
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
I think this needs to be implemented as per: https://opentelemetry.io/docs/specs/otel/metrics/sdk/#configuration-1 In particular cardinality can be set on views rather than globally. |
We are removing Views from initial stable release, so this can only be on a MetricReader or most likely on MeterProvider level only for now. |
@bnjjj - Not sure if I am missing something, but how can this method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is unclear to this works. See #1889 (comment)
The ideal way is via views, but we should hold off from offering that, given Views are being removed for 1st stable release.
Closing inactive PRs. This is definitely something we need for metrics, and hoping to bring it in next 1-2 releases. |
Fixes #1065
Changes
Adding a new function called
set_stream_cardinality_limit
inopentelemetry_sdk::metrics
module to set the stream cardinality limit for metric streams.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes