Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visibility of AttributeSet from pub to pub(crate) #2045

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Aug 22, 2024

AttributeSet is no longer required to be a public type. It's only used internally

Changes

  • Update visibility of AttributeSet from pub to pub(crate)
  • Remove unnecessary methods
  • Deleted the related benchmark file (benchmarks can't access AttributeSet now)

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team August 22, 2024 20:42
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.1%. Comparing base (673c328) to head (3690084).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2045   +/-   ##
=====================================
  Coverage   77.1%   77.1%           
=====================================
  Files        123     123           
  Lines      21103   21088   -15     
=====================================
  Hits       16275   16275           
+ Misses      4828    4813   -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bye dear AttributeSet! You served us well, ensuring Metric identity and correct aggregation for a long time. Now you can continue to do so, but internally ;)

@lalitb
Copy link
Member

lalitb commented Aug 23, 2024

Deleted the related benchmark file (benchmarks can't access AttributeSet now)

That's one of the bottleneck with pub(crate) :(

@cijothomas cijothomas merged commit 916a117 into open-telemetry:main Aug 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants