update trait Number<T> to Number

[fraillt]

Changes

Simply updated trait Number<T> by removing unnecessary generic type from it.

There is exactly these changes (you can repeat it in 1 min)

• search for regex Number(<[a-zA-Z0-9]*>) replace with Number
• in trait Number replace T with Self.

What is the value? It's easier to understand to newcomers such as myself :)

Merge requirement checklist

• CONTRIBUTING guidelines followed
• Unit tests added/updated (if applicable)
• Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
• Changes in public API reviewed (if applicable)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: fraillt / name: Mindaugas Vinkelis (06cf36f)

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.3%. Comparing base (b2e5640) to head (06cf36f).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...-sdk/src/metrics/internal/exponential_histogram.rs	71.4%	2 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2109   +/-   ##
=====================================
  Coverage   78.3%   78.3%           
=====================================
  Files        121     121           
  Lines      20815   20815           
=====================================
  Hits       16309   16309           
  Misses      4506    4506           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cijothomas]

Thanks for another cleanup/simplification. The existing thing was probably done to meet some needs in the Histogram aggregation, not quite sure why.
This is still good to merge, and we can do another deep review/cleanup of Histograms.

(Histograms SUM should always be double, but looks like we have it as <T>. Good to check it further after this PR.)

[cijothomas]

/easycla check

[cijothomas]

/easycla

[cijothomas]

Looks like CLA is failing, similar to communitybridge/easycla#4329

[fraillt]

Looks like CLA is failing, similar to communitybridge/easycla#4329

Sorry... I keep forgetting ;(

[fraillt]

This is still good to merge, and we can do another deep review/cleanup of Histograms.

I'm actually looking at this right now :) it seams that both ExpoHistogram and Histogram could share some logic.
At the moment I see at least few issues:

• ExpoHistogram - uses it's own implementation for attribute tracking, instead of utilizing ValueMap, and for this reason it doesn't have is_under_cardinality_limit check, and other improvements.
• Histogram - uses ValueMap which is optimized for AtomicOperations, but histogram measurements cannot be performed in atomic maneir, fo this reason every measurement get's atleast to locks: one for attribute map, another for actually updating histogram aggregate.

So If I'll create a new revision soon to address this ;)

[cijothomas]

ExponentialHistogram was left out from initial set of changes to leverage ValueMap, just to keep scope under control!
Yes if we can somehow avoid the dual lock (1st one is really a read lock) for histogram, that'd be awesome.

[cijothomas]

Merging, as CLA issue is resolved. Other proposals looks good, happy to accept them via follow up PRs!