[OTLP Exporter] Use env for endpoint, timeout #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 47.91% 48.42% +0.51%
==========================================
Files 95 95
Lines 8739 8739
==========================================
+ Hits 4187 4232 +45
+ Misses 4552 4507 -45
Continue to review full report at Codecov.
|
ozerovandrei
force-pushed
the
168-otlp-span-exporter-env-cfg
branch
2 times, most recently
from
918464d to
de53bb3
Compare
TommyCpp
reviewed
Feb 7, 2021
TommyCpp
approved these changes
Feb 8, 2021
djc
reviewed
Feb 8, 2021
ozerovandrei
force-pushed
the
168-otlp-span-exporter-env-cfg
branch
from
6df2280 to
bcf9774
Compare
Add `with_env` method for `OtlpPipelineBuilder`. This method currently only configures `endpoint` and `timeout` for OTLP Traces exporter. Add default constants for those parameters and use them for the default `ExporterConfig`. Use values defined in specification. Add basic tests for the new method.
Check that env variables were unset after test.
ozerovandrei
force-pushed
the
168-otlp-span-exporter-env-cfg
branch
from
bcf9774 to
f1596ed
Compare
|
Ok sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
with_envmethod forOtlpPipelineBuilder. This method currentlyonly configures
endpointandtimeoutfor OTLP Traces exporter.Add default constants for those parameters and use them for the default
ExporterConfig. Use values defined in specification.Add basic tests for the new method.
Specification reference: exporter.md
Part of #168