Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release(v0.19): add initial change log #965

Merged
merged 9 commits into from
Mar 26, 2023

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Feb 7, 2023

We are still blocked by some memory issue investigation but once it resolved we should be able to cut a release

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8cc3ee3) 69.9% compared to head (023b8b8) 69.9%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #965   +/-   ##
=====================================
  Coverage   69.9%   69.9%           
=====================================
  Files        116     116           
  Lines       9027    9027           
=====================================
+ Hits        6310    6315    +5     
+ Misses      2717    2712    -5     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TommyCpp TommyCpp marked this pull request as ready for review February 13, 2023 08:40
@TommyCpp TommyCpp requested a review from a team February 13, 2023 08:40
@djc
Copy link
Contributor

djc commented Feb 13, 2023

I think we should deal with #969 before releasing.

Is it intentional that the integration tests job is getting skipped in CI? Should we run it manually before release?

@TommyCpp
Copy link
Contributor Author

Is it intentional that the integration tests job is getting skipped in CI?

Yeah I intend to expand the integration test coverage so I expect the time to run it grows over time. And it may not needed to run for every commit/PR. But we should run it before release.

@TommyCpp TommyCpp added the integration tests Run integration tests label Feb 14, 2023
@TommyCpp
Copy link
Contributor Author

Listed the following issues as blocking before 0.19 release, feel free to add more:

@hdost
Copy link
Contributor

hdost commented Mar 12, 2023

@TommyCpp Is the blocker still the memory issue?

@TommyCpp
Copy link
Contributor Author

@TommyCpp Is the blocker still the memory issue?

No the memory issue is false alarm for this repo(the issue is not in our crate) so we are good on that front. I can update the changelog but we probably still need #901 to sign LCA?

@hdost
Copy link
Contributor

hdost commented Mar 16, 2023

Should we place a time limit on the #901 change, if it's not merged by X date then we merge and release?

@TommyCpp
Copy link
Contributor Author

Should we place a time limit on the #901 change, if it's not merged by X date then we merge and release?

Plan to cut release this weekend. We can do a minor release for #901 if needed

@TommyCpp
Copy link
Contributor Author

I think that's all changes we want to land in v0.19. PTAL cc @open-telemetry/rust-approvers

@jtescher
Copy link
Member

@TommyCpp should we release version 0.20.0 as a follow up once #1000 lands?

@TommyCpp
Copy link
Contributor Author

@TommyCpp should we release version 0.20.0 as a follow up once #1000 lands?

Yep I think #1000 contains lots of change and maybe released as follow up.

I will wait until tomorrow to gather more thoughts for this release. But if there is not I will merge it.

@glynnmccabe
Copy link
Contributor

@TommyCpp the datadog export is broken for version 05. I made a small fix here: #1002

Tested locally and working as expected.

Would be nice to get this in the release if possible :)

@TommyCpp TommyCpp merged commit 879d6ff into open-telemetry:main Mar 26, 2023
@hdost
Copy link
Contributor

hdost commented Mar 26, 2023

🚀 thank you @TommyCpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants