Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add otel_scope_info and scope labels #974

Merged

Conversation

zengxilong
Copy link
Contributor

PR for #930

  1. Add otel_scope_name and otel_scope_version attributes to all metrics based on the instrumentation scope name and version.
  2. Add an otel_scope_info metric.
  3. Add prometheus exporter config, provide a disable_scope_info flag to disable the otel_scope_info metric and otel_scope_ labels.
  4. I will make a new PR to resolve collisions between TYPE, HELP, and UNIT comments.

@zengxilong zengxilong requested a review from a team February 26, 2023 18:22
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 69.9% // Head: 69.9% // Decreases project coverage by -0.1% ⚠️

Coverage data is based on head (a1d40a0) compared to base (931faea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #974     +/-   ##
=======================================
- Coverage   69.9%   69.9%   -0.1%     
=======================================
  Files        116     116             
  Lines       8920    8920             
=======================================
- Hits        6243    6237      -6     
- Misses      2677    2683      +6     
Impacted Files Coverage Δ
opentelemetry-http/src/lib.rs 3.6% <0.0%> (-5.5%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Overall like a good start. I think maybe use something like with_scope_info will be more clear. And we can have the default value to be true

opentelemetry-prometheus/src/lib.rs Outdated Show resolved Hide resolved
@zengxilong zengxilong requested a review from hdost February 27, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants