-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add otel_scope_info and scope labels #974
feat: add otel_scope_info and scope labels #974
Conversation
Codecov ReportBase: 69.9% // Head: 69.9% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #974 +/- ##
=======================================
- Coverage 69.9% 69.9% -0.1%
=======================================
Files 116 116
Lines 8920 8920
=======================================
- Hits 6243 6237 -6
- Misses 2677 2683 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Overall like a good start. I think maybe use something like with_scope_info
will be more clear. And we can have the default value to be true
PR for #930