Skip to content

Commit

Permalink
Make exemplar default language normative (#4009)
Browse files Browse the repository at this point in the history
I'm making my best guess of what was intended. If the language should
use `SHOULD` or `MAY` please comment.
  • Loading branch information
alanwest authored Apr 24, 2024
1 parent c9489dd commit 8c61382
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -1105,13 +1105,13 @@ The SDK MUST include two types of built-in exemplar reservoirs:

By default:

- Explicit bucket histogram aggregation with more than 1 bucket will
- Explicit bucket histogram aggregation with more than 1 bucket SHOULD
use `AlignedHistogramBucketExemplarReservoir`.
- Base2 Exponential Histogram Aggregation SHOULD use a
`SimpleFixedSizeExemplarReservoir` with a reservoir equal to the
smaller of the maximum number of buckets configured on the aggregation or
twenty (e.g. `min(20, max_buckets)`).
- All other aggregations will use `SimpleFixedSizeExemplarReservoir`.
- All other aggregations SHOULD use `SimpleFixedSizeExemplarReservoir`.

Exemplar default reservoirs MAY change in
a [minor version bump](./../versioning-and-stability.md#minor-version-bump). No
Expand Down

0 comments on commit 8c61382

Please sign in to comment.