Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DistributedContext specification is incomplete #242

Closed
Oberon00 opened this issue Sep 2, 2019 · 5 comments
Closed

DistributedContext specification is incomplete #242

Oberon00 opened this issue Sep 2, 2019 · 5 comments
Milestone

Comments

@Oberon00
Copy link
Member

Oberon00 commented Sep 2, 2019

  • The distributed context specification talks about scope (in the conflict resolution section) but does not define it.
  • Relatedly, there is no notion of a current context and consequently no way to get it.
  • The API, as defined in the spec, provides no way to add values to the distributed context.

In Java, all of this is implemented in the DistributedContextManager (it seems that Tracer : Span ~ DistributedContextManager : DistributedContext).

@Oberon00
Copy link
Member Author

Oberon00 commented Sep 2, 2019

Should this be rectified in a simple PR (that simply follows the Java "reference" implementation) or is an OTEP required?

@songy23
Copy link
Member

songy23 commented Sep 2, 2019

DistributedContext may be renamed. See open-telemetry/oteps#36.

@Oberon00
Copy link
Member Author

Oberon00 commented Sep 2, 2019

I assume that was just a side note, since renaming would not change anything about the points I raised 😃

@tedsuo
Copy link
Contributor

tedsuo commented Sep 3, 2019

@Oberon00 in short, the current API is half baked and we hope to finish baking it this week. :)

There's was a lot of discussion last week to hammer out details around DistributedContext. You can find the notes here, under "Context Propagation Discussion": https://docs.google.com/document/d/1rgXZik2_-2fU1KpVi7nze5ygWA8NhaLE8VmD20H4P8M/edit#heading=h.o5slz8bi8org

We hope to get some proposals out this week, based on this discussion, which will hopefully provide a cleaner proposal for context propagation in general.

@tedsuo
Copy link
Contributor

tedsuo commented Dec 4, 2019

This work has continued as an OTEP: open-telemetry/oteps#66

@tedsuo tedsuo closed this as completed Dec 4, 2019
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants