-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "canonical" adjective from Status Code #1081
Remove "canonical" adjective from Status Code #1081
Conversation
6e7bf74
to
a64d3cb
Compare
Please add an entry in the changelog and preferably a spec compliance matrix entry to keep track of the renamings for GA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tigrannajaryan Please consider applying the suggested changes, StatusCode
seems to be the preferred name as per the 👍s and would also solve the issue you mentioned in open-telemetry/opentelemetry-proto#224 (comment).
a64d3cb
to
05e514b
Compare
Changelog entry added. Spec compliance matrix does not require changes since it refers to simply "status". |
I thought of a separate entry for keeping track of SIGs adopting the renaming before releasing them as RC/GA. |
I think that is what changelog is intended for. Maintainers need to check the changelog to know what they may need to change in the implementation. |
Yes, that's how maintainers are notified about the change, but the GC/TC will look at the spec compliance matrix to determine whether an implementation fulfills the spec requirements for RC/GA - at least that's my understanding. |
* Remove "canonical" adjective from Status Code Resolves: open-telemetry#1069 * Address PR comments
Resolves: #1069