Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the fallback case for service.name #1269

Merged
merged 19 commits into from
Dec 14, 2020
Merged

Define the fallback case for service.name #1269

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2cf2cf9
Define the fallback case for service.name
carlosalberto Dec 1, 2020
adb4a6f
Update specification/resource/semantic_conventions/README.md
carlosalberto Dec 1, 2020
9199c75
Add a mention of fallback values in Resource Creation.
carlosalberto Dec 2, 2020
4c8bc87
Add details on the fallback name.
carlosalberto Dec 2, 2020
85114d7
Try to update the service.yaml definition.
carlosalberto Dec 2, 2020
2af2f4a
Update.
carlosalberto Dec 2, 2020
399aedc
Update specification/resource/sdk.md
carlosalberto Dec 2, 2020
acd342a
Merge branch 'master' into service_name_fallback
carlosalberto Dec 3, 2020
7d29c88
Apply more feedback.
carlosalberto Dec 9, 2020
e68dca8
Fix bad style.
carlosalberto Dec 9, 2020
e832c9d
Merge branch 'master' into service_name_fallback
carlosalberto Dec 9, 2020
a39a1ee
Merge branch 'master' into service_name_fallback
carlosalberto Dec 10, 2020
2e2a2fb
Update specification/resource/semantic_conventions/README.md
carlosalberto Dec 11, 2020
d629603
Update specification/resource/semantic_conventions/README.md
carlosalberto Dec 11, 2020
09e6100
Merge branch 'master' into service_name_fallback
carlosalberto Dec 12, 2020
cd78297
Re-run the semantic convention generation step.
carlosalberto Dec 12, 2020
aa0dccc
Make service.instance.id non-required.
carlosalberto Dec 12, 2020
c8d43c8
Merge branch 'master' into service_name_fallback
carlosalberto Dec 14, 2020
b63c3a0
Update CHANGELOG.
carlosalberto Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions specification/resource/semantic_conventions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ Certain attribute groups in this document have a **Required** column. For these
| `service.version` | string | The version string of the service API or implementation. | `2.0.0` | No |

**[1]:** MUST be the same for all instances of horizontally scaled services.
Although this is a required attribute, if the value could not be specified SDKs
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved
MUST fallback to a language-specific name based on the running service.
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved
If this fallback fails, the name MUST default to `unknown_service`.
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved

**[2]:** A string value having a meaning that helps to distinguish a group of services, for example the team name that owns a group of services. `service.name` is expected to be unique within the same namespace. If `service.namespace` is not specified in the Resource then `service.name` is expected to be unique for all services that have no explicit namespace defined (so the empty/unspecified namespace is simply one more valid namespace). Zero-length namespace string is assumed equal to unspecified namespace.

Expand Down