-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowercased ECS launch types #1339
Lowercased ECS launch types #1339
Conversation
Looks like the semantic-conventions check is failing for an unrelated reason. Verified locally that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add an entry in the changelog about this?
For @willarmiros :) |
@bogdandrutu done :) Not sure why I'm getting failures on semantic-conventions again :/ |
The output says: |
@Oberon00 Right, and I'm confused because I didn't touch $ docker run --rm -v $(pwd)/semantic_conventions:/source -v $(pwd)/specification:/spec otel/semconvgen -f /source markdown -md /spec --md-check
58 files left unchanged. |
@thisthat Do you have an idea what could be the problem? |
It looks like the wrong version is used. There was a new release a few hours ago. Now that we have a release with a proper version, we should pin the semantic tool to tag 0.2.1. EDIT: I've created #1381 |
@thisthat you're right that was it, thanks! Looks like a lot of markdown just got updated with whitespace and other auto-generated changes. |
* lowercased ECS launch types * updated changelog * updated tables with 2.1 tool Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Changes