Adding draft SLA to issue-management.md file #163
Conversation
thomashchan1
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
There was a problem hiding this comment.
Overall, I have some concerns about putting the SLA into CONTRIBUTING.md instead of somewhere in the community repo, most likely as SIG membership requirements.
I believe that putting these sorts of requirements on non-core participants will deter potential contributors and other newcomers to the product. On the other hand, moving them into (eg) SIG membership requirements may help us preserve the general goal of addressing end-user issues quickly.
thomashchan1
changed the title
|
@AloisReitbauer, @bogdandrutu, @c24t, @reyang, @SergeyKanzhelev, @songy23, @rghetia and/or @yurishkuro, please review the updated SLA changes, namely:
|
|
LGTM |
|
@yurishkuro would love to find ways to measure these via automation. Will see if I can find anything that we can use. Anyone else has suggestions, please send them to our Gitter channel or comment here. In the interim, will need to depend on all of us to identify gaps, politely call them out so that we can address them and get better together. |
| - For smaller or internal changes: 1 approval from a different company. | ||
| - For `URGENT` issues: | ||
| - Collaborator: please provide initial assessment of the issues to OP ASAP or | ||
| within 1 business day, whichever is earlier. |
There was a problem hiding this comment.
"ASAP or within X" seems to have the same logic as "up to X% off or more" -- it could describe any number.
There was a problem hiding this comment.
The intention here is to highlight the request for quick response while stating the upper limit. Let me know your thoughts.
There was a problem hiding this comment.
How about something like this?
"Please provide an initial assessment of the issue within 1 business day. URGENT issues are time-sensitive. Collaborators should prioritize the assessment and responses to review comments above other work and respond as quickly as possible."
"As quickly as possible" still feels fishy to me since this is what SLAs are meant to solve.
There was a problem hiding this comment.
Understood @c24t . Given this is community based and not really the same as enforceable within one company, suspect this is as good as we can get in terms of prescribing the intent. One question is while this sounds better and more descriptive as well, do you (or anyone else) feel comfortable duplicating this, with some minor adjustment, 2 other times for URGENT issue SLA vs the existing shorter versions? For other minor comments above, I am planning to resolve them to move things along. Let me know otherwise or feel free to re-open if you have strong feelings on those. Thanks again for spending the time to provide input.
There was a problem hiding this comment.
@c24t let me know your thoughts on this. Would like to get this merged soon. Thanks in advance.
Co-Authored-By: Chris Kleinknecht <libc@google.com>
* Update CONTRIBUTING.md * Create issue-management.md * Update issue-management.md Co-Authored-By: Chris Kleinknecht <libc@google.com>
* Update CONTRIBUTING.md * Create issue-management.md * Update issue-management.md Co-Authored-By: Chris Kleinknecht <libc@google.com>
Added draft SLA for issues and PRs in CONTRIBUTING.md