Limit view-rename capabilities in the presence of multi-select views #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Nov 24, 2021
cijothomas
reviewed
Nov 24, 2021
reyang
reviewed
Nov 24, 2021
reyang
reviewed
Nov 24, 2021
reyang
reviewed
Nov 24, 2021
reyang
added
area:sdk
jack-berg
reviewed
Nov 30, 2021
|
@cijothomas / @jack-berg - I retweaked the wording here. Cijo - I reworded this to make sure it's understood it applies to view registration where criteria is provided apriori (not the callback approach, which I think falls outside this specification). Jack - Retweaked the wording you provided with the limitation we feel like we need in the spec right now. |
jack-berg
approved these changes
Dec 3, 2021
aabmass
approved these changes
Dec 7, 2021
jmacd
approved these changes
Dec 10, 2021
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
jmacd
reviewed
Dec 10, 2021
jmacd
approved these changes
Dec 10, 2021
MrAlias
approved these changes
Dec 10, 2021
cijothomas
approved these changes
Dec 10, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…pen-telemetry#2168) * Limit view-rename capabilities in the presence of multi-select of instruments. * Fixes from review. * Fixes from reivew. * Update specification/metrics/sdk.md Co-authored-by: Aaron Abbott <aaronabbott@google.com> * Update specification/metrics/sdk.md * Update specification/metrics/sdk.md Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com> Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2141