[metrics] Allow setting ExemplarFilter via View API #4014
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ExemplarFilter
via the View APIDetails
In .NET we have decided to NOT enable
Exemplar
s by default due to performance considerations. If users wantExemplar
s they can set anExemplarFilter
at theMeterProvider
level. This will carry a performance hit for all measurements.We feel users may only want to pay for the performance hit on critical metrics. With the current specification design, users don't have a lot of options to accomplish this. Really the only thing which may be done is enable
Exemplar
s for theMeterProvider
and then use the View API to set anExemplarReservoir
which dropsExemplar
s for any/all metrics where they aren't desired.The proposed addition here is seeking to make it easier to selectively enable or disable
Exemplar
s at the instrument-level.For non-trivial changes, follow the change proposal process.
CHANGELOG.md
file updated for non-trivial changesspec-compliance-matrix.md
updated if necessary