Add details for determining the parent Span from a Context #423
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
yurishkuro
reviewed
Jan 25, 2020
mwear
force-pushed
the
context_prop_span_parentage_updates
branch
from
b63f14b to
ed3200a
Compare
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
|
I should have batched the suggestions, but thanks for the review @yurishkuro. |
carlosalberto
approved these changes
Jan 25, 2020
yurishkuro
approved these changes
Jan 26, 2020
arminru
reviewed
Jan 27, 2020
jmacd
approved these changes
Jan 27, 2020
dyladan
reviewed
Jan 27, 2020
arminru
approved these changes
Jan 28, 2020
yurishkuro
changed the title
bogdandrutu
approved these changes
Jan 28, 2020
MikeGoldsmith
added a commit
to MikeGoldsmith/opentelemetry-specification
that referenced
this pull request
Feb 6, 2020
…elemetry-specification into remove-binary-format * 'remove-binary-format' of github.com:MikeGoldsmith/opentelemetry-specification: update Resource spec based on the move to the SDK and named tracers (open-telemetry#421) sdk-tracer: replace Factory with Provider (open-telemetry#422) Add details for determining the parent Span from a Context (open-telemetry#423)
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
…metry#423) * Add details for parenting a span from a context * Integrate suggested feedback * Apply suggestion Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> * Apply suggestion Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> * Apply suggestion Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> * Add comma Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Rephrase parenting a span * Fix broken link Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Armin Ruech <armin.ruech@gmail.com> Co-authored-by: Bogdan Drutu <lazy@splunk.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…metry#423) * Add details for parenting a span from a context * Integrate suggested feedback * Apply suggestion Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> * Apply suggestion Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> * Apply suggestion Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> * Add comma Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Rephrase parenting a span * Fix broken link Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Armin Ruech <armin.ruech@gmail.com> Co-authored-by: Bogdan Drutu <lazy@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTEP 66 has a section where it offers guidance on how to parent a
Spangiven aContext. This PR integrates those details into the api-tracing spec.The bulk of this PR is the following text:
Parenting from a Context
When a new
Spanis created from aContextthere are several scenarios toconsider when selecting a parent. A
Contextcan contain:SpanSpanContextSpanand an extractedSpanContextSpanor an extractedSpancontextIn order handle these scenarios, a convention has been established for assigning
a parent from a
Context. The precedence for parent selection is as follows:Span.SpanContext.Span.