-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend semantic conventions for RPC and allow non-gRPC calls #604
Merged
bogdandrutu
merged 15 commits into
open-telemetry:master
from
dynatrace-oss-contrib:semconv-rpc
Jun 17, 2020
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e6f2125
Generalize RPC semantic conventions to allow non-gRPC spans
arminru 7eb02c4
Add method name to attributes
arminru 8d2b396
Require specifying `net.transport` for non-IP connections
arminru 16fe294
Do not require providing the port when it's not available
arminru b8837ce
Add package name to rpc.service and make it optional when not applica…
arminru cc57fed
Add note and example distinguishing the service.name resource attribu…
arminru 90d403e
Distinguish RPC spans from HTTP spans
arminru 201c8f4
Improve wording
arminru 5569c39
Improve wording
arminru 40d40c3
Improve wording even more
arminru 07ffad7
Clarify span name format
arminru fccca5f
Update changelog
arminru da98d44
rpc.method: required -> recommended
arminru bed40c9
Merge branch 'master' into semconv-rpc
arminru b817129
rpc.service: required -> recommended
arminru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Common RPC conventions
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you suggest to shorten the heading or are you questioning the wording?