Rename ParentOrElse to ParentBased and generalize to support all cases #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
arminru,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
yurishkuro
reviewed
May 18, 2020
carlosalberto
added
spec:trace
carlosalberto
added
the
release:required-for-ga
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
carlosalberto
approved these changes
Aug 19, 2020
bogdandrutu
force-pushed
the
parentnotremote
branch
from
92ee24b
to
6887038
Compare
bogdandrutu
force-pushed
the
parentnotremote
branch
from
6887038
to
ef31217
Compare
bogdandrutu
changed the title
|
@carlosalberto please review again, because I incorporated the feedback from @Oberon00. |
bogdandrutu
force-pushed
the
parentnotremote
branch
from
ef31217
to
0880a0a
Compare
yurishkuro
reviewed
Aug 19, 2020
yurishkuro
reviewed
Aug 19, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
parentnotremote
branch
from
e13ef33
to
ccf7ff5
Compare
carlosalberto
approved these changes
Aug 20, 2020
|
(The latest) improvements look good! @yurishkuro Please approve if you think all your issues are solved (else, comment ;) ) |
arminru
approved these changes
Aug 20, 2020
yurishkuro
approved these changes
Aug 20, 2020
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Aug 21, 2020
carlosalberto
added a commit
that referenced
this pull request
Aug 21, 2020
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…n-telemetry#610) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Add CHANGELOG entry for open-telemetry#610 * Update CHANGELOG.md Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com> Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.