Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a single configuration #820

Merged
merged 6 commits into from
Aug 19, 2020

Conversation

codeboten
Copy link
Contributor

The following change describes that the OTLP exporter must support configuration for all signals via a single set of configuration options. There is also an example for configuring different signals with different endpoints via environment variables.

Fixes #790

Related issues #699 #681

The following change describes that the OTLP exporter must support configuration for all signals via a single set of configuration options. There is also an example for configuring different signals with different endpoints via environment variables.
@codeboten codeboten requested review from a team and SergeyKanzhelev August 17, 2020 21:09
@carlosalberto carlosalberto added area:sdk Related to the SDK spec:trace Related to the specification/trace directory spec:metrics Related to the specification/metrics directory labels Aug 18, 2020
@SergeyKanzhelev
Copy link
Member

Last small nit: please add a reference to this page from one of high level docs. So it will be discoverable

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really love if the reference to this doc will be added to one of the higher-level docs/TOCs so the page will be discoverable

@codeboten
Copy link
Contributor Author

I'd really love if the reference to this doc will be added to one of the higher-level docs/TOCs so the page will be discoverable

Link has been added @SergeyKanzhelev

specification/protocol/exporter.md Outdated Show resolved Hide resolved
specification/protocol/README.md Outdated Show resolved Hide resolved
@carlosalberto carlosalberto self-requested a review August 19, 2020 14:24
@bogdandrutu
Copy link
Member

non controversial, merging

@bogdandrutu bogdandrutu merged commit a6943fd into open-telemetry:master Aug 19, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Allow specifying a single configuration

The following change describes that the OTLP exporter must support configuration for all signals via a single set of configuration options. There is also an example for configuring different signals with different endpoints via environment variables.

* adding a third example

* moving otlp exporter into protocol directory

* add link to exporter from readme

* apply review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP Exporter must support single configuration for all signals
5 participants