-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default propagator in unconfigured API #930
Merged
carlosalberto
merged 19 commits into
open-telemetry:master
from
SergeyKanzhelev:defaultPropagatorsVariant
Sep 18, 2020
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d693fb9
note on default propagators
SergeyKanzhelev 5a86d55
changelog update
SergeyKanzhelev 1068789
pr number
SergeyKanzhelev c1163f0
addressed PR feedback
SergeyKanzhelev 8c780e3
Update specification/context/api-propagators.md
SergeyKanzhelev 21661b0
Update specification/context/api-propagators.md
SergeyKanzhelev 07beb2b
Update specification/context/api-propagators.md
SergeyKanzhelev 0d5874c
Update specification/context/api-propagators.md
SergeyKanzhelev 7d7373d
Update specification/context/api-propagators.md
SergeyKanzhelev be8db72
Update specification/context/api-propagators.md
SergeyKanzhelev 5e5e396
Update specification/context/api-propagators.md
SergeyKanzhelev 8291c18
Update specification/context/api-propagators.md
SergeyKanzhelev 8fb1886
Update specification/context/api-propagators.md
SergeyKanzhelev ff6c08d
Update specification/context/api-propagators.md
SergeyKanzhelev d3dcff8
Merge branch 'master' into defaultPropagatorsVariant
SergeyKanzhelev 6102d64
Merge remote-tracking branch 'upstream/master' into defaultPropagator…
SergeyKanzhelev 3840f9d
a few clarificaiton to address PR review
SergeyKanzhelev 3f44162
Update specification/context/api-propagators.md
SergeyKanzhelev 270de4a
Update specification/context/api-propagators.md
SergeyKanzhelev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's meant by "global accessors"? Via global getters?
We could also more generically say "available as global properties on the API".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what's written is also generic enough. Let me know if this is blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking (I already approved the PR) but a bit unclear to me.