Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Ignore to Drop for SamplingResult #956

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Rename Ignore to Drop for SamplingResult #956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Returns the sampling Decision for a `Span` to be created.
It produces an output called `SamplingResult` which contains:

* A sampling `Decision`. One of the following enum values:
* `IGNORE` - `IsRecording() == false`, span will not be recorded and all events and attributes
* `DROP` - `IsRecording() == false`, span will not be recorded and all events and attributes
will be dropped.
* `RECORD_ONLY` - `IsRecording() == true`, but `Sampled` flag MUST NOT be set.
* `RECORD_AND_SAMPLE` - `IsRecording() == true` AND `Sampled` flag` MUST be set.
Expand All @@ -120,7 +120,7 @@ The default sampler is `ParentBased(root=AlwaysOn)`.

#### AlwaysOff

* Returns `IGNORE` always.
* Returns `DROP` always.
* Description MUST be `AlwaysOffSampler`.

#### TraceIdRatioBased
Expand Down