Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid processing undesired network tasks #458

Conversation

nachoBonafonte
Copy link
Member

Avoid processing undesired network tasks activity when the task has not been processed properly by urlSessionTaskWillResume. We check if a taskId was registered or exit early.
Should fix remaining crashes in #447

…cessed properly by urlSessionTaskWillResume. We check if a taskId was registered or exit early, should fix remaining crashes in open-telemetry#447
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage is 12.50% of modified lines.

❗ Current head 702421f differs from pull request most recent head ae373f9. Consider uploading reports for the commit ae373f9 to get more accurate results

Files Changed Coverage
...ntation/URLSession/URLSessionInstrumentation.swift 12.50%

📢 Thoughts on this report? Let us know!.

@nachoBonafonte nachoBonafonte merged commit 5c74e87 into open-telemetry:main Sep 20, 2023
4 checks passed
@nachoBonafonte nachoBonafonte deleted the Avoid-handling-undesired-network-tasks branch September 28, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants