Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include response length by default in the network spans #464

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Include response length by default in the network spans #464

merged 3 commits into from
Sep 29, 2023

Conversation

nachoBonafonte
Copy link
Member

It reports Content-Length http header in the http.response_content_length attribute
Fixes #463

@nachoBonafonte nachoBonafonte linked an issue Sep 28, 2023 that may be closed by this pull request
NSURLSesssion instrumentation should capture http.response.body.size #463
Closed
Ignacio Bonafonte added 2 commits September 28, 2023 18:56
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Files Coverage Δ
Sources/OpenTelemetryApi/OpenTelemetry.swift 50.00% <ø> (ø)
...penTelemetrySdk/Resources/ResourceAttributes.swift 33.33% <ø> (ø)
.../Instrumentation/URLSession/URLSessionLogger.swift 94.55% <75.00%> (-1.77%) ⬇️
...es/OpenTelemetryApi/Trace/SemanticAttributes.swift 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@bryce-b bryce-b merged commit 30c2a5a into open-telemetry:main Sep 29, 2023
4 checks passed
@nachoBonafonte nachoBonafonte deleted the 463-nsurlsesssion-instrumentation-should-capture-httpresponsebodysize branch November 16, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryce-b bryce-b bryce-b approved these changes

@vvydier vvydier Awaiting requested review from vvydier vvydier is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSURLSesssion instrumentation should capture http.response.body.size
2 participants
@nachoBonafonte @bryce-b