Allow async instrument to close via observable #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade swift-nio package to fix security issue CVE-2022-3252
Update Package.swift
This reverts commit 29447c4.
…se the measurement (cherry picked from commit 44f041e)
hunguyenaxon
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
bryce-b
approved these changes
Oct 9, 2023
vvydier
approved these changes
Oct 9, 2023
hunguyenaxon
deleted the
hunguyen-467-469-allow-gauge-instrument-close
branch
hunguyenaxon
restored the
hunguyen-467-469-allow-gauge-instrument-close
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR for #467 and #469
The changes follow to Android version (link) where all kind of observable can close its associated instrument