Allow the DoubleHistogramInstrument to record value #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunguyenaxon
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
hunguyenaxon
commented
Oct 9, 2023
| //TODO: implement | ||
| public func record(value: Double, attributes: [String: OpenTelemetryApi.AttributeValue]) { | ||
| if value < 0 { | ||
| print("Histograms can only record non-negative values. Instrument \(instrumentDescriptor.name) has recorded a negative value.") |
There was a problem hiding this comment.
The log message is following to Android version (link)
@Override
public void record(long value, Attributes attributes, Context context) {
if (value < 0) {
throttlingLogger.log(
Level.WARNING,
"Histograms can only record non-negative values. Instrument "
+ getDescriptor().getName()
+ " has recorded a negative value.");
return;
}
storage.recordLong(value, attributes, context);
}
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
bryce-b
approved these changes
Oct 9, 2023
hunguyenaxon
deleted the
hunguyen-468-fix-record-double-histogram-metric
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is for #468
As per in
LongHistogramMeterSdk, we need to record the value forDoubleHistogramInstrumentas well