Fixed removeContextValue function and added a Test testRemoveContextValuesFromSpan for it #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
==========================================
- Coverage 66.34% 66.34% -0.01%
==========================================
Files 336 336
Lines 14408 14406 -2
==========================================
- Hits 9559 9557 -2
Misses 4849 4849 ☔ View full report in Codecov by Sentry. |
bryce-b
approved these changes
Dec 20, 2023
nachoBonafonte
approved these changes
Dec 20, 2023
bryce-b
reviewed
Dec 21, 2023
Tests/OpenTelemetryApiTests/Context/ActivityContextManagerTests.swift
Outdated
Show resolved
Hide resolved
…f explicitly calling removeContextValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this with a span and added it to 2 parent spans in different threads. Total of 5 contexts getting removed in this case.
Tested with a crude mechanism (using sleep) for now. Will improve it with a Semaphore or async/await later.