Expands LogRecord to allow "anyValue" in body parameter. #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
==========================================
+ Coverage 66.33% 66.42% +0.09%
==========================================
Files 336 336
Lines 14406 14446 +40
==========================================
+ Hits 9556 9596 +40
Misses 4850 4850 ☔ View full report in Codecov by Sentry. |
|
That looks like the right way to do it! I created the spec-change branch after I modified the ActivityContextManager code and test case in my main, so it also shows up here. Do you think it would be ok to merge this or do we need to remove the ActivityContextManager updates from this PR? |
nachoBonafonte
requested changes
Dec 21, 2023
There was a problem hiding this comment.
LGTM, but there are some changes that I think are part of another PR from @vvydier
Tests/OpenTelemetryApiTests/Context/ActivityContextManagerTests.swift
Outdated
Show resolved
Hide resolved
nachoBonafonte
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.