Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data compression support for HTTP exporter #631

Merged

Conversation

mamunto
Copy link
Contributor

@mamunto mamunto commented Nov 6, 2024

HTTP client didn't have any compression support. In this PR I made following changes

  • Extracted DataCompression from DataDogExporter and made new target
  • Introduced gzip and deflate compression support

@mamunto
Copy link
Contributor Author

mamunto commented Nov 6, 2024

@nachoBonafonte any thought on Linux platform support? We will need a completely different cross-platform library. Let's discuss to find a solution.

@mamunto mamunto force-pushed the mdalmamun/otel-http-export-gzip branch from bbc08ab to 7f8d941 Compare November 7, 2024 18:48
@mamunto
Copy link
Contributor Author

mamunto commented Nov 8, 2024

It would be nice if we can include this PR and here is another in next release. Really appreciate your time and help

Copy link
Contributor

@vvydier vvydier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. All the tests passed as well

@nachoBonafonte nachoBonafonte merged commit 60f9260 into open-telemetry:main Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants