Added exporter metric for Span, Trace and Log #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mamunto
commented
Nov 14, 2024
mamunto
commented
- Added convenience initializer to support metrics for Span, Trace and Log
- Followed Java SDK
mamunto
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
mamunto
force-pushed
the
mdalmamun/add-metrics-to-exporter
branch
from
7acee4e to
b234a83
Compare
|
This looks great. Can you add a documentation comment to the new init explaining the new parameter? |
mamunto
force-pushed
the
mdalmamun/add-metrics-to-exporter
branch
from
b234a83 to
804a9f2
Compare
Done! |
bryce-b
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.