added other AV task exceptions in NSURLSession instrumentation #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batuhansk
suggested changes
Nov 21, 2024
| if let avAssetTaskClass = Self.avAssetDownloadTask, | ||
| task.isKind(of: avAssetTaskClass) { | ||
| return | ||
| for aClass in Self.AVTaskClassList { |
There was a problem hiding this comment.
contains(where:) would be more idiomatic.
guard !Self.AVTaskClassList.contains(where: { task.isKind(of: $0) }) else { return }
|
|
||
| static let AVTaskClassList : [AnyClass] = { | ||
| let names = ["__NSCFBackgroundAVAggregateAssetDownloadTask", "__NSCFBackgroundAVAssetDownloadTask", "__NSCFBackgroundAVAggregateAssetDownloadTaskNoChildTask" ] | ||
| var classes : [AnyClass] = [] |
There was a problem hiding this comment.
let classes = names.compactMap { NSClassFromString($0) }
return classes
vvydier
approved these changes
Nov 21, 2024
bryce-b
force-pushed
the
session-instrumentation-AV-fix
branch
from
eda5b4d to
b799e43
Compare
batuhansk
approved these changes
Nov 22, 2024
nachoBonafonte
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are additional AV download tasks that need to be accounted for.
Related issues : elastic/apm-agent-ios#242